Bump jackson_version - Fix GHSA-72hv-8253-57qq #37969
Bump jackson_version - Fix GHSA-72hv-8253-57qq #37969stankiewicz wants to merge 2 commits intoapache:masterfrom
Conversation
jackson-core: Number Length Constraint Bypass in Async Parser Leads to Potential DoS Condition
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a necessary security update by bumping the Jackson library version. This change mitigates a known vulnerability that could be exploited to cause a Denial of Service, ensuring the stability and security of the project's dependencies. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Assigning reviewers: R: @kennknowles for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
In the past there were security fixes caused regressions: #26743. From 2.15 to 2.18 there are several more: Gemini said is there potential concern for these listed changes and/or there are others |
|
well, it may break user code at edge cases - very long property names, very large jsons with plenty of tokens per element, nested. Most scary is is about different constructor picked up. |
GHSA-72hv-8253-57qq
jackson-core: Number Length Constraint Bypass in Async Parser Leads to Potential DoS Condition
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.