Skip to content

Fix CloudML Benchmarks Dataflow job #36269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damccorm merged 1 commit into from
Sep 25, 2025
Merged

Fix CloudML Benchmarks Dataflow job #36269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdks/python/apache_beam/testing/benchmarks/cloudml/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@
# limitations under the License.
#

dill
Copy link
Contributor

@damccorm damccorm Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - I see that this does indeed cause the correct test set to run, and avoids

beam/sdks/python/apache_beam/examples/ml_transform/ml_transform_it_test.py

Line 34 in b8f0d5f

raise unittest.SkipTest('tensorflow_transform is not installed.')

Do you know which import in that block requires dill?

Copy link
Collaborator

@claudevdm claudevdm Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tensorflow-transform actually requires dill (but doesnt specify in its setup.py). It was always transitively included via apache-beam. See tensorflow/transform#345

Copy link
Contributor

@damccorm damccorm Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks - missed that this was the same issue

tfx_bsl
tensorflow-transform
Loading