[AVRO-4044][C++] Add time-nanos logical type #3147
Draft
+26
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glywk
force-pushed
the
cpp_time_nanos
branch
from
0b609d0
to
9af3ff3
Compare
mkmkme
approved these changes
Sep 4, 2024
Gerrit0
approved these changes
Sep 6, 2024
|
The PR is set to Draft until #3125 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVRO-4044
What is the purpose of the change
To align with nanoseconds precision of timestamps and local timestamps, I would propose adding this precision to the time logical type Avro specification as well. Propose a C++ implementation of AVRO-4043
Verifying this change
This change added tests and can be verified as follows:
time_nanosis applied on good and wrong avro primitive type.Documentation