Skip to content

Conversation

@tabish121
Copy link
Contributor

Add more detailed documentation for AMQP federation convering more of the configuration options and example configurations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do the arrows specifically represent here? Are they based on what the underlying federation would be doing given the message demand from the consumers and the message supply from the producer? If so, I would expect there to be no arrow between Spoke 3 and the Hub since there is neither demand or supply on Spoke 3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arrows represent a consumer link with the arrow point to where the messages flow. There is demand on the other spokes which means the hub listens on the spoke in case messages are delivered there as it needs to forward them to where there is demand.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not always intuitive and it was a bit hard to create diagrams that don't get way to busy trying to show what's going on. I was trying to keep from adding to much actual implementation details but eventually we might want to expand on things more as folks ask questions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some clarification in that paragraph about the linkages between nodes

Add more detailed documentation for AMQP federation convering more of the
configuration options and example configurations.
@tabish121 tabish121 force-pushed the amqp-federation-docs branch from f80aa31 to 48f030d Compare December 10, 2025 21:36
@jbertram
Copy link
Contributor

The convention we've adopted for AsciiDoc uses one sentence-per-line. I see that being used in some places, but not in others.

@tabish121
Copy link
Contributor Author

The convention we've adopted for AsciiDoc uses one sentence-per-line. I see that being used in some places, but not in others.

Is there a technical reason for that, it makes actually writing them god awful.

@jbertram
Copy link
Contributor

jbertram commented Dec 10, 2025

We manually wrapped our previous mark-down docs which was extremely tedious and prone to mess up. Lines with no wrapping are a pain to scroll down and read. Soft wrapping is an option in some cases, but not all.

The sentence-per-line convention is a balance of the two options, and it's recommended by the AsciiDoc folks for a number of reasons.

For what it's worth, I've not found the process to be a hindrance or an annoyance. Is there something specific that's "god awful"? 😆

@tabish121
Copy link
Contributor Author

We manually wrapped our previous mark-down docs which was extremely tedious and prone to mess up. Lines with no wrapping are a pain to scroll down and read. Soft wrapping is an option in some cases, but not all.

The sentence-per-line convention is a balance of the two options, and it's recommended by the AsciiDoc folks for a number of reasons.

For what it's worth, I've not found the process to be a hindrance or an annoyance. Is there something specific that's "god awful"? 😆

I won't ever remember to do it, so will always have to go back and do it as I apparently will now, and reading it either involves endless scrolling for long sentences or a jumbled mess if you use auto wrap. In any case I will mark this as draft and try and find some motivation to fix it later.

@tabish121 tabish121 marked this pull request as draft December 10, 2025 22:25
@jbertram
Copy link
Contributor

jbertram commented Dec 10, 2025

If you use the AsciiDoctor plugin for IntelliJ you can just do Ctrl-Alt-Shift-F and the plugin will format everything correctly.

I've been using this plugin for a few years now and found it quite useful.

@tabish121
Copy link
Contributor Author

Not everyone uses intellij

@jbertram
Copy link
Contributor

Done.

Explain a bit more of the linkages between nodes when demand is applied on a spoke.
@tabish121
Copy link
Contributor Author

Done.

Thanks, that saves me some eye strain

@tabish121 tabish121 marked this pull request as ready for review December 10, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants