ARTEMIS-5782 - improve control object filtering #6097
Draft
+1,590
−666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also some perf tweaks added
andytaylor
force-pushed
the
controlsort
branch
3 times, most recently
from
3581eda to
f1cb1c8
Compare
jbertram
reviewed
Dec 3, 2025
| AddressControlImpl addressControl = new AddressControlImpl(addressInfo, messagingServer, pagingManager, storageManager, securityRepository, securityStore, this); | ||
| registerInJMX(objectNameBuilder.getAddressObjectName(addressInfo.getName()), addressControl); | ||
| registerInRegistry(ResourceNames.ADDRESS + addressInfo.getName(), addressControl); | ||
| registerAddressControls(ResourceNames.ADDRESS + addressInfo.getName(), addressControl); |
Contributor
There was a problem hiding this comment.
This should replace the call to registerInRegistry, no?
jbertram
reviewed
Dec 3, 2025
| public void unregisterAddress(final SimpleString address) throws Exception { | ||
| unregisterFromJMX(objectNameBuilder.getAddressObjectName(address)); | ||
| unregisterFromRegistry(ResourceNames.ADDRESS + address); | ||
| unregisterAddressControls(ResourceNames.ADDRESS + address); |
Contributor
There was a problem hiding this comment.
This should replace the call to unregisterFromRegistry, no?
jbertram
reviewed
Dec 3, 2025
|
|
||
| Object invokeOperation(String resourceName, String operation, Object[] params, SecurityAuth auth) throws Exception; | ||
|
|
||
| List<QueueControl> getQueueControls(Predicate<QueueControl> predicate); |
Contributor
There was a problem hiding this comment.
Consider adding:
List<QueueControl> getQueueControls();That way folks wouldn't have to pass null to get all the controls. Passing null isn't intuitive.
jbertram
reviewed
Dec 3, 2025
| List<QueueControl> getQueueControls(Predicate<QueueControl> predicate); | ||
|
|
||
| List<AddressControl> getAddressControls(Predicate<AddressControl> predicate); | ||
| } |
jbertram
reviewed
Dec 3, 2025
| // we keep a second map just for queues for quick searching when many exist | ||
| private final Map<String, QueueControl> queueControls; | ||
|
|
||
| // we keep a second map just for queues for quick searching when many exist |
andytaylor
force-pushed
the
controlsort
branch
2 times, most recently
from
c473c73 to
14c9f91
Compare
andytaylor
force-pushed
the
controlsort
branch
from
14c9f91 to
23949b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.