GH-22342: [C++] [Documentation] Clarify Union type ids - #50839
Open
erichanwang wants to merge 2 commits into
Open
GH-22342: [C++] [Documentation] Clarify Union type ids#50839erichanwang wants to merge 2 commits into
erichanwang wants to merge 2 commits into
Conversation
|
|
Author
|
Formatting follow-up:
|
uros-b
approved these changes
Aug 10, 2026
Member
|
Nice focused improvement, LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Union layout documentation does not explain that the type IDs stored in the types buffer can differ from the child array indices, or how the optional
typeIdsmetadata maps children to physical type IDs.What changes are included in this PR?
typeIdsmetadata.Fixes #22342.
Are these changes tested?
git diff --checkpasses and the RST change was reviewed againstSchema.fbsand the existing Union layout documentation. A local Sphinx/RST checker is not installed in this environment.Are there any user-facing changes?
No.