GH-49295: [Python] Remove "mimalloc" from mandatory_backends#49645
Open
kou wants to merge 1 commit intoapache:mainfrom
Open
GH-49295: [Python] Remove "mimalloc" from mandatory_backends#49645kou wants to merge 1 commit intoapache:mainfrom
mandatory_backends#49645kou wants to merge 1 commit intoapache:mainfrom
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
This PR updates PyArrow’s memory-pool tests to avoid assuming mimalloc is always available, aligning the test expectations with builds where mimalloc is disabled (e.g., some downstream distro packages).
Changes:
- Remove
"mimalloc"frommandatory_backendsso tests only require the"system"allocator backend.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
raulcd
approved these changes
Apr 2, 2026
Member
raulcd
left a comment
There was a problem hiding this comment.
As per the conversation on the issue, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
mimalloc is enabled by default but users can disable it. For example, Debian package disables it.
If it's disabled, PyArrow tests are failed.
What changes are included in this PR?
Remove
"mimalloc"frommandatory_backendsin our test.Are these changes tested?
Yes.
Are there any user-facing changes?
No.
-DARROW_MIMALLOC=OFF#49295