GH-49087 [CI][Packaging][Gandiva] Add support for LLVM 15 or earlier again #49091
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obs fail compiling Gandiva
|
|
github-actions
bot
added
Component: C++
Component: Gandiva
awaiting review
kou
changed the title
|
|
1 similar comment
|
|
kou
approved these changes
Jan 31, 2026
Comment on lines
+233
to
+237
| #if LLVM_VERSION_MAJOR >= 16 | ||
| jit_builder.setDataLayout(std::make_optional(data_layout)); | ||
| #else | ||
| jit_builder.setDataLayout(llvm::Optional<llvm::DataLayout>(data_layout)); | ||
| #endif |
Member
There was a problem hiding this comment.
This may work:
Suggested change
| #if LLVM_VERSION_MAJOR >= 16 | |
| jit_builder.setDataLayout(std::make_optional(data_layout)); | |
| #else | |
| jit_builder.setDataLayout(llvm::Optional<llvm::DataLayout>(data_layout)); | |
| #endif | |
| jit_builder.setDataLayout(data_layout); |
github-actions
bot
added
awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
LLVM 15 or earlier uses
llvm::Optionalnotstd::optional.What changes are included in this PR?
Use
llvm::Optionalwith LLVM 15 or earlier.Are these changes tested?
Yes, compiling.
Are there any user-facing changes?
No