GH-48755: [MATLAB] Rename getArrayProxyIDs to getProxyIDs #48756
+20
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
requested review from
kevingurney,
kou and
sgilmore10
as code owners
|
|
github-actions
bot
added
awaiting merge
sgilmore10
approved these changes
Jan 8, 2026
Member
sgilmore10
left a comment
sgilmore10
left a comment
There was a problem hiding this comment.
Thanks for fixing this! getProxyIDs is a much better name!
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 0c49503. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The internal helper function
getArrayProxyIDswas misleadingly named since it works with both Arrays and RecordBatches, not just arrays.What changes are included in this PR?
getArrayProxyIDs.mtogetProxyIDs.mAre these changes tested?
Existing tests cover functionality.
Are there any user-facing changes?
No, dev-only.