Skip to content

GH-48220: [C++][Parquet] Fix arrow-buffer & arrow-misc testcase failures to enable Parquet DB support on s390x #48221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-48220: [C++][Parquet] Fix arrow-buffer & arrow-misc testcase failures to enable Parquet DB support on s390x #48221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cpp/src/arrow/buffer_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
#include "arrow/status.h"
#include "arrow/testing/gtest_util.h"
#include "arrow/util/checked_cast.h"
#include "arrow/util/endian.h"

namespace arrow {

Expand Down Expand Up @@ -996,7 +997,8 @@ TYPED_TEST(TypedTestBuffer, TypedResize) {

TYPED_TEST(TypedTestBuffer, ResizeOOM) {
// This test doesn't play nice with AddressSanitizer
#ifndef ADDRESS_SANITIZER
// Skip this test on big-endian architectures (e.g., s390x)
#if !defined(ADDRESS_SANITIZER) && ARROW_LITTLE_ENDIAN
// realloc fails, even though there may be no explicit limit
TypeParam buf;
ASSERT_OK_AND_ASSIGN(buf, AllocateResizableBuffer(0));
Expand Down
4 changes: 3 additions & 1 deletion cpp/src/arrow/memory_pool_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include "arrow/status.h"
#include "arrow/testing/gtest_util.h"
#include "arrow/util/config.h"
#include "arrow/util/endian.h"
#include "arrow/util/logging.h"

namespace arrow {
Expand Down Expand Up @@ -68,8 +69,9 @@ TYPED_TEST_SUITE_P(TestMemoryPool);

TYPED_TEST_P(TestMemoryPool, MemoryTracking) { this->TestMemoryTracking(); }

// Skip this test on big-endian architectures (e.g., s390x)
TYPED_TEST_P(TestMemoryPool, OOM) {
#ifndef ADDRESS_SANITIZER
#if !defined(ADDRESS_SANITIZER) && ARROW_LITTLE_ENDIAN
this->TestOOM();
#endif
}
Expand Down
Loading