GH-47945: [C++] Add support for Boost 1.89.0 and require Boost 1.69 or later #47947
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
@lahwaacz Could you try this? |
|
@kou This seems to work, thanks! |
Boost.System is header-only since Boost 1.69. CentOS 7 uses Boost 1.69. So we can drop support for Boost 1.68 or older.
|
Thanks. I'll merge this in a few days if nobody objects this. |
raulcd
reviewed
Oct 28, 2025
| gmock>=1.10.0 | ||
| google-cloud-cpp>=1.34.0 | ||
| gtest>=1.10.0 | ||
| libboost-devel |
| # enable CMP0167 "The FindBoost module is removed." | ||
| # https://cmake.org/cmake/help/latest/policy/CMP0167.html with CMake | ||
| # 3.30.0 or later. | ||
| set(Boost_ADDITIONAL_VERSIONS |
There was a problem hiding this comment.
I don't understand why we don't have to add "1.89.0" here.
I understand that we will have to remove this once CMake >= 3.30.0 but from https://cmake.org/cmake/help/latest/module/FindBoost.html it doesn't seem like 1.89.0 should not be added to this list. Do you know why this is not required?
github-actions
bot
added
awaiting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Boost 1.89.0 removed backward compatibility CMake package for Boost.System. Boost.System is header-only since Boost 1.69. So CMake package for Boost.System isn't needed but it's provided for backward compatibility.
CentOS 7 uses Boost 1.69. So we can drop support for Boost 1.68 or older.
What changes are included in this PR?
systemfromCOMPONENTSbecause Boost.System is header-only.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.