-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-46137: [C++] Replace grpc-cpp conda package with libgrpc #47606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
6a81372
to
1b03f5b
Compare
ninja | ||
nodejs | ||
orc | ||
orc<2.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In CI orc is pinned to 1.9.0. This new pin is required due to some upstream bugs with the CMake configuration - see apache/orc#2408
The Go failure seems related although I'm not sure I can see anything in the logs that points to the issue. Maybe @zeroshade has an idea? https://github.com/apache/arrow/actions/runs/17863409077/job/50799734977?pr=47606#step:13:1204 |
Indeed the package was renamed (similar to the conda package for arrow going from |
1b03f5b
to
7308d5d
Compare
7308d5d
to
27db46e
Compare
OK this is all green - @kou any thoughts on this? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 4b55ea6. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 17 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
The grpc-cpp conda package appears abandoned and is artificially pinning other dependencies to older versions (ex: orc). The more recent libgrpc conda package appears to be where the development is going forward
What changes are included in this PR?
Replaced grpc-cpp with libgrpc
Are these changes tested?
Yes
Are there any user-facing changes?
No