Skip to content

Conversation

WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Sep 19, 2025

Rationale for this change

The grpc-cpp conda package appears abandoned and is artificially pinning other dependencies to older versions (ex: orc). The more recent libgrpc conda package appears to be where the development is going forward

What changes are included in this PR?

Replaced grpc-cpp with libgrpc

Are these changes tested?

Yes

Are there any user-facing changes?

No

Copy link

⚠️ GitHub issue #47605 has been automatically assigned in GitHub to PR creator.

ninja
nodejs
orc
orc<2.1.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In CI orc is pinned to 1.9.0. This new pin is required due to some upstream bugs with the CMake configuration - see apache/orc#2408

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Sep 19, 2025
@WillAyd
Copy link
Contributor Author

WillAyd commented Sep 19, 2025

The Go failure seems related although I'm not sure I can see anything in the logs that points to the issue. Maybe @zeroshade has an idea?

https://github.com/apache/arrow/actions/runs/17863409077/job/50799734977?pr=47606#step:13:1204

@h-vetinari
Copy link
Contributor

The grpc-cpp conda package appears abandoned and is artificially pinning other dependencies to older versions (ex: orc). The more recent libgrpc conda package appears to be where the development is going forward

Indeed the package was renamed (similar to the conda package for arrow going from arrow-cpp to libarrow) and we eventually dropped the compatibility wrapper for the old naming, which is why the last available builds will pull in very old dependencies.

@WillAyd
Copy link
Contributor Author

WillAyd commented Sep 27, 2025

It looks like the integration failure here was reported by @kou upstream in #47673

FWIW it has happened with every push so far on this branch, but maybe that has been bad luck

@WillAyd
Copy link
Contributor Author

WillAyd commented Oct 4, 2025

OK this is all green - @kou any thoughts on this?

@WillAyd WillAyd changed the title GH-47605: [C++] Replace grpc-cpp conda package with libgrpc GH-46137: [C++] Replace grpc-cpp conda package with libgrpc Oct 4, 2025
Copy link

github-actions bot commented Oct 4, 2025

⚠️ GitHub issue #46137 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 4b55ea6 into apache:main Oct 6, 2025
31 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Oct 6, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Oct 6, 2025
Copy link

After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 4b55ea6.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 17 possible false positives for unstable benchmarks that are known to sometimes produce them.

@WillAyd WillAyd deleted the replace-grpc-cpp branch October 6, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants