-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-47588: [C++] Bump mimalloc version to 3.1.5 #47589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
79182eb
to
f79033d
Compare
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
e27d1e8
to
709942b
Compare
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
@ursabot please benchmark |
Benchmark runs are scheduled for commit 709942b. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
Thanks for your patience. Conbench analyzed the 4 benchmarking runs that have been run so far on PR commit 709942b. There were 80 benchmark results indicating a performance regression:
The full Conbench report has more details. |
709942b
to
57aecbf
Compare
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
57aecbf
to
696a5c0
Compare
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
25d7290
to
0a0c9b2
Compare
@github-actions crossbow submit -g cpp -g linux -g r |
@github-actions crossbow submit cp313 |
|
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit -g cpp -g r |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
According to microsoft/mimalloc#1073 , mimalloc v3 is preferred over v2 for production usage.
68da2a9
to
4294e34
Compare
@github-actions crossbow submit -g cpp -g r cp313 |
Revision: 4294e34 Submitted crossbow builds: ursacomputing/crossbow @ actions-562e16c367 |
### Rationale for this change According to microsoft/mimalloc#1073 , mimalloc v3 is preferred over v2 for production usage. There are reports of higher than expected memory consumption with mimalloc 2.2.x, notably when reading Parquet data (example: GH-47266). ### What changes are included in this PR? Bump to mimalloc 3.1.5, which is the latest mimalloc 3.1.x release as of this writing. ### Are these changes tested? Yes, by existing tests and CI. ### Are there any user-facing changes? Hopefully not, besides a potential reduction in memory usage due to improvements in mimalloc v3. * GitHub Issue: #47588 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit e1f727c. There were 5 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 16 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
According to microsoft/mimalloc#1073 , mimalloc v3 is preferred over v2 for production usage.
There are reports of higher than expected memory consumption with mimalloc 2.2.x, notably when reading Parquet data (example: GH-47266).
What changes are included in this PR?
Bump to mimalloc 3.1.5, which is the latest mimalloc 3.1.x release as of this writing.
Are these changes tested?
Yes, by existing tests and CI.
Are there any user-facing changes?
Hopefully not, besides a potential reduction in memory usage due to improvements in mimalloc v3.