-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45137: [CI][C++] Add a GCC 15 job #45138
Conversation
@github-actions crossbow submit test-debian-experimental-cpp-gcc-15 |
|
Revision: a857e02 Submitted crossbow builds: ursacomputing/crossbow @ actions-48d932260e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
As you mentioned in #44970, this doesn't yet work because we have (at least one...) deprecated use so will need to improve C++20 for this to go cleanly.
What do you think about adding ~test-debian-experimental-cpp-gcc-15
so this job is excluded from running automatically, but we can make PRs to do the cleanup for C++20 and still confirm that those are getting us closer?
to
Line 159 in a857e02
- test-* |
Line 76 in a857e02
- test-* |
clang${llvm_package_suffix} \ | ||
g++${gcc_package_suffix} \ | ||
gcc${gcc_package_suffix} \ | ||
llvm${llvm_package_suffix}-dev && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, cleaver using a suffix that when it is ""
just installs the default. Nice.
r: ${R} | ||
base: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-cpp | ||
gcc_version: ${GCC_VERSION} | ||
tz: ${TZ} | ||
r_prune_deps: ${R_PRUNE_DEPS} | ||
gcc: ${GCC} | ||
r: ${R} | ||
r_duckdb_dev: ${R_DUCKDB_DEV:-} | ||
r_prune_deps: ${R_PRUNE_DEPS} | ||
tz: ${TZ} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just s/GCC_VERSION/GCC/
and then alphabetically ordering, yeah?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
It's a good idea! I've added it. |
TODO: https://github.com/ursacomputing/crossbow/actions/runs/12559814148/job/35016145241#step:7:5301
We should use See also:
(I think that we should work on this as a separated task.) |
Rationale for this change
GCC 15 isn't released yet but we'll be able to add support for the latest GCC in a timely manner with this.
What changes are included in this PR?
Add a GCC 15 job based on Debian GNU/Linux experimental.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.