Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45137: [CI][C++] Add a GCC 15 job #45138

Merged
merged 2 commits into from
Jan 1, 2025
Merged

GH-45137: [CI][C++] Add a GCC 15 job #45138

merged 2 commits into from
Jan 1, 2025

Conversation

kou
Copy link
Member

@kou kou commented Dec 31, 2024

Rationale for this change

GCC 15 isn't released yet but we'll be able to add support for the latest GCC in a timely manner with this.

What changes are included in this PR?

Add a GCC 15 job based on Debian GNU/Linux experimental.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
Copy link
Member Author

kou commented Dec 31, 2024

@github-actions crossbow submit test-debian-experimental-cpp-gcc-15

Copy link

⚠️ GitHub issue #45137 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Dec 31, 2024
@kou kou mentioned this pull request Dec 31, 2024
Copy link

Revision: a857e02

Submitted crossbow builds: ursacomputing/crossbow @ actions-48d932260e

Task Status
test-debian-experimental-cpp-gcc-15 GitHub Actions

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

As you mentioned in #44970, this doesn't yet work because we have (at least one...) deprecated use so will need to improve C++20 for this to go cleanly.

What do you think about adding ~test-debian-experimental-cpp-gcc-15 so this job is excluded from running automatically, but we can make PRs to do the cleanup for C++20 and still confirm that those are getting us closer?

to

- test-*
and
- test-*

Comment on lines +92 to +95
clang${llvm_package_suffix} \
g++${gcc_package_suffix} \
gcc${gcc_package_suffix} \
llvm${llvm_package_suffix}-dev && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, cleaver using a suffix that when it is "" just installs the default. Nice.

Comment on lines -1520 to +1524
r: ${R}
base: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-cpp
gcc_version: ${GCC_VERSION}
tz: ${TZ}
r_prune_deps: ${R_PRUNE_DEPS}
gcc: ${GCC}
r: ${R}
r_duckdb_dev: ${R_DUCKDB_DEV:-}
r_prune_deps: ${R_PRUNE_DEPS}
tz: ${TZ}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just s/GCC_VERSION/GCC/ and then alphabetically ordering, yeah?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions github-actions bot added awaiting merge Awaiting merge awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review awaiting merge Awaiting merge labels Dec 31, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 31, 2024
@kou
Copy link
Member Author

kou commented Dec 31, 2024

What do you think about adding ~test-debian-experimental-cpp-gcc-15 so this job is excluded from running automatically, but we can make PRs to do the cleanup for C++20 and still confirm that those are getting us closer?

It's a good idea! I've added it.

@kou
Copy link
Member Author

kou commented Dec 31, 2024

TODO:

https://github.com/ursacomputing/crossbow/actions/runs/12559814148/job/35016145241#step:7:5301

FAILED: src/arrow/CMakeFiles/arrow_array.dir/array/array_nested.cc.o 
/usr/local/bin/sccache /usr/lib/ccache/g++-15 -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 -DARROW_WITH_TIMING_TESTS -I/build/cpp/src -I/arrow/cpp/src -I/arrow/cpp/src/generated -Wredundant-move -Wno-noexcept-type -Wno-self-move  -fdiagnostics-color=always  -Wall -Wno-conversion -Wno-sign-conversion -Wdate-time -Wimplicit-fallthrough -Wunused-result -fno-semantic-interposition -msse4.2  -g -Werror -O0 -ggdb -g1 -std=c++20 -fPIC -MD -MT src/arrow/CMakeFiles/arrow_array.dir/array/array_nested.cc.o -MF src/arrow/CMakeFiles/arrow_array.dir/array/array_nested.cc.o.d -o src/arrow/CMakeFiles/arrow_array.dir/array/array_nested.cc.o -c /arrow/cpp/src/arrow/array/array_nested.cc
/arrow/cpp/src/arrow/array/array_nested.cc: In member function 'const std::shared_ptr<arrow::Array>& arrow::StructArray::field(int) const':
/arrow/cpp/src/arrow/array/array_nested.cc:1080:51: error: 'std::shared_ptr<_Tp> std::atomic_load(const shared_ptr<_Tp>*) [with _Tp = arrow::Array]' is deprecated: use 'std::atomic<std::shared_ptr<T>>' instead [-Werror=deprecated-declarations]
 1080 |   std::shared_ptr<Array> result = std::atomic_load(&boxed_fields_[i]);
      |                                   ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
In file included from /usr/include/c++/15/memory:83,
                 from /arrow/cpp/src/arrow/array/array_nested.h:24,
                 from /arrow/cpp/src/arrow/array/array_nested.cc:18:
/usr/include/c++/15/bits/shared_ptr_atomic.h:142:5: note: declared here
  142 |     atomic_load(const shared_ptr<_Tp>* __p)
      |     ^~~~~~~~~~~
/arrow/cpp/src/arrow/array/array_nested.cc:1089:22: error: 'void std::atomic_store(shared_ptr<_Tp>*, shared_ptr<_Tp>) [with _Tp = arrow::Array]' is deprecated: use 'std::atomic<std::shared_ptr<T>>' instead [-Werror=deprecated-declarations]
 1089 |     std::atomic_store(&boxed_fields_[i], std::move(result));
      |     ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/15/bits/shared_ptr_atomic.h:183:5: note: declared here
  183 |     atomic_store(shared_ptr<_Tp>* __p, shared_ptr<_Tp> __r)
      |     ^~~~~~~~~~~~
/arrow/cpp/src/arrow/array/array_nested.cc: In member function 'std::shared_ptr<arrow::Array> arrow::UnionArray::field(int) const':
/arrow/cpp/src/arrow/array/array_nested.cc:1360:51: error: 'std::shared_ptr<_Tp> std::atomic_load(const shared_ptr<_Tp>*) [with _Tp = arrow::Array]' is deprecated: use 'std::atomic<std::shared_ptr<T>>' instead [-Werror=deprecated-declarations]
 1360 |   std::shared_ptr<Array> result = std::atomic_load(&boxed_fields_[i]);
      |                                   ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
/usr/include/c++/15/bits/shared_ptr_atomic.h:142:5: note: declared here
  142 |     atomic_load(const shared_ptr<_Tp>* __p)
      |     ^~~~~~~~~~~
/arrow/cpp/src/arrow/array/array_nested.cc:1372:22: error: 'void std::atomic_store(shared_ptr<_Tp>*, shared_ptr<_Tp>) [with _Tp = arrow::Array]' is deprecated: use 'std::atomic<std::shared_ptr<T>>' instead [-Werror=deprecated-declarations]
 1372 |     std::atomic_store(&boxed_fields_[i], result);
      |     ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/15/bits/shared_ptr_atomic.h:183:5: note: declared here
  183 |     atomic_store(shared_ptr<_Tp>* __p, shared_ptr<_Tp> __r)
      |     ^~~~~~~~~~~~
cc1plus: all warnings being treated as errors

We should use std::atomic<std::shared_ptr> instead of std::atomic_load()/std::atomic_store(). std::atomic_load()/std::atomic_store() are deprecated and they are replaced with std::atomic<std::shared_ptr> in C++20.

See also:

(I think that we should work on this as a separated task.)

@jonkeane jonkeane merged commit 0b6a687 into apache:main Jan 1, 2025
34 of 35 checks passed
@jonkeane jonkeane removed the awaiting change review Awaiting change review label Jan 1, 2025
@kou kou deleted the ci-gcc-15 branch January 2, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants