Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45073: [C++][Parquet] Fix generation of repetition levels for encryption test data #45074

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamreeve
Copy link
Contributor

@adamreeve adamreeve commented Dec 19, 2024

Rationale for this change

This makes the test data readable by other Parquet implementations that validate the repetition levels.

What changes are included in this PR?

  • Corrects the generation of encryption test files so that the int64 list columns correctly start lists with repetition level 0.
  • Updates the parquet-testing submodule to use the corrected files (TODO)

Are these changes tested?

Yes, covered by existing tests.

Are there any user-facing changes?

No

@adamreeve
Copy link
Contributor Author

The tests will fail until the test data is first fixed in apache/parquet-testing#65 and the submodule updated here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant