Skip to content

GH-49295: [Python] Remove "mimalloc" from mandatory_backends#49645

Merged
kou merged 1 commit intoapache:mainfrom
kou:python-test-memory-mimalloc
Apr 3, 2026
Merged

GH-49295: [Python] Remove "mimalloc" from mandatory_backends#49645
kou merged 1 commit intoapache:mainfrom
kou:python-test-memory-mimalloc

Conversation

@kou
Copy link
Copy Markdown
Member

@kou kou commented Apr 2, 2026

Rationale for this change

mimalloc is enabled by default but users can disable it. For example, Debian package disables it.

If it's disabled, PyArrow tests are failed.

What changes are included in this PR?

Remove "mimalloc" from mandatory_backends in our test.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copilot AI review requested due to automatic review settings April 2, 2026 09:24
@kou kou requested review from AlenkaF, raulcd and rok as code owners April 2, 2026 09:24
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

⚠️ GitHub issue #49295 has been automatically assigned in GitHub to PR creator.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates PyArrow’s memory-pool tests to avoid assuming mimalloc is always available, aligning the test expectations with builds where mimalloc is disabled (e.g., some downstream distro packages).

Changes:

  • Remove "mimalloc" from mandatory_backends so tests only require the "system" allocator backend.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the conversation on the issue, LGTM

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Apr 2, 2026
@kou kou merged commit ddc4229 into apache:main Apr 3, 2026
22 checks passed
@kou kou deleted the python-test-memory-mimalloc branch April 3, 2026 00:03
@kou kou removed the awaiting merge Awaiting merge label Apr 3, 2026
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ddc4229.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 59 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants