Allow UTC & +00:00 to be written in parquet writer#9994
Open
xanderbailey wants to merge 7 commits into
Open
Conversation
hareshkh
approved these changes
May 18, 2026
xanderbailey
commented
May 18, 2026
| /// native array | ||
| fn types_compatible(a: &DataType, b: &DataType) -> bool { | ||
| // if the Arrow data types are equal, the types are deemed compatible | ||
| if a.equals_datatype(b) { |
Contributor
Author
There was a problem hiding this comment.
Open question if this new logic belongs in equals_datatype
Contributor
Author
There was a problem hiding this comment.
Moving to equals_datatype gets us the recursive checks for free so I think this might make more sense?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Working towards: #3199
Rationale for this change
types_compatiblewill error today like so:When datafusion creates a UTC timestamp but iceberg-rust is expecting to see a "+00:00". These two are semantically the same so we should allow the parquet write.
What changes are included in this PR?
Slacken the
types_compatibleto allow UTC equivalent timestamps when writing parquet.Are these changes tested?
Are there any user-facing changes?