minor: Add coverage for LogicalType::Variant to tests#9981
Open
etseidl wants to merge 2 commits into
Open
Conversation
etseidl
commented
May 18, 2026
| }, | ||
| LogicalType::Integer { | ||
| bit_width: 8, | ||
| bit_width: 16, |
Contributor
Author
There was a problem hiding this comment.
Small drive-by fixup. We were testing i8 four times
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
While experimenting with a new form for
LogicalTypeI found some tests forLogicalTypeinbasic.rsdid not cover theVariantvariant.What changes are included in this PR?
Add coverage. Also fixes lack of coverage for
i16,i32, and 'i64` for one test.Are these changes tested?
Yes
Are there any user-facing changes?
No, tests only