Skip to content

feat(parquet): Add ParquetPushDecoder::into_builder to allow swapping projections / row filters at row group boundaries #9968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 9 commits into from
May 20, 2026
Merged

feat(parquet): Add ParquetPushDecoder::into_builder to allow swapping projections / row filters at row group boundaries #9968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ab4d277
feat(parquet): add ParquetPushDecoder::swap_strategy for adaptive scans
adriangb Apr 27, 2026
fee4744
fix(parquet): drop private intra-doc link from swap_strategy docs
adriangb Apr 28, 2026
b75d300
test(parquet): cover projection swap with incremental I/O
adriangb May 13, 2026
748e9cf
refactor(parquet): replace swap_strategy with ParquetPushDecoder::int…
adriangb May 15, 2026
0fcf0db
feat(parquet): preserve buffered bytes across ParquetPushDecoder::int…
adriangb May 15, 2026
92ee0ca
docs(parquet): add adaptive-scan example to ParquetPushDecoderBuilder
adriangb May 15, 2026
e3c71cd
refactor(parquet): rename push decoder input to PushInput, drop new(0…
adriangb May 15, 2026
890bd68
refactor(parquet): address review feedback on push decoder into_builder
adriangb May 15, 2026
a92f5e1
add note
adriangb May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions parquet/src/arrow/arrow_reader/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,12 @@ pub const DEFAULT_BATCH_SIZE: usize = 1024;
pub struct ArrowReaderBuilder<T> {
/// The "input" to read parquet data from.
///
/// Note in the case of the [`ParquetPushDecoderBuilder`], there
/// is no underlying input, which is indicated by a type parameter of [`NoInput`]
/// Note in the case of the [`ParquetPushDecoderBuilder`] there is no
/// underlying reader; the input is instead [`PushDecoderInput`], the buffer that
/// caller-pushed bytes accumulate in.
///
/// [`ParquetPushDecoderBuilder`]: crate::arrow::push_decoder::ParquetPushDecoderBuilder
/// [`NoInput`]: crate::arrow::push_decoder::NoInput
/// [`PushDecoderInput`]: crate::arrow::push_decoder::PushDecoderInput
pub(crate) input: T,

pub(crate) metadata: Arc<ParquetMetaData>,
Expand Down
4 changes: 2 additions & 2 deletions parquet/src/arrow/async_reader/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ pub use metadata::*;
mod store;

use crate::DecodeResult;
use crate::arrow::push_decoder::{NoInput, ParquetPushDecoder, ParquetPushDecoderBuilder};
use crate::arrow::push_decoder::{ParquetPushDecoder, ParquetPushDecoderBuilder, PushDecoderInput};
#[cfg(feature = "object_store")]
pub use store::*;

Expand Down Expand Up @@ -600,7 +600,7 @@ impl<T: AsyncFileReader + Send + 'static> ParquetRecordBatchStreamBuilder<T> {
let projected_schema = Arc::new(Schema::new(projected_fields));

let decoder = ParquetPushDecoderBuilder {
input: NoInput,
input: PushDecoderInput::default(),
metadata,
schema,
fields,
Expand Down
Loading
Loading