[Variant] Add unshred_variant support for Binary and LargeBinary types#9576
Merged
alamb merged 3 commits intoapache:mainfrom Mar 20, 2026
Merged
[Variant] Add unshred_variant support for Binary and LargeBinary types#9576alamb merged 3 commits intoapache:mainfrom
alamb merged 3 commits intoapache:mainfrom
Conversation
Signed-off-by: Kunal Singh Dadhwal <kunalsinghdadhwal@gmail.com>
Signed-off-by: Kunal Singh Dadhwal <kunalsinghdadhwal@gmail.com>
Contributor
Author
|
Kindly review @sdf-jkl |
sdf-jkl
approved these changes
Mar 19, 2026
Contributor
sdf-jkl
left a comment
There was a problem hiding this comment.
Thanks @kunalsinghdadhwal! LGTM.
Run cargo fmt to fix lint and we'll ask someone with approval rights to push this forward.
Signed-off-by: Kunal Singh Dadhwal <kunalsinghdadhwal@gmail.com>
Contributor
Author
Done |
Contributor
|
@scovich please take a look when available. Thanks! |
scovich
approved these changes
Mar 19, 2026
Contributor
scovich
left a comment
There was a problem hiding this comment.
LGTM! Thanks for filling the gap
Contributor
|
Thanks @scovich and @sdf-jkl and @kunalsinghdadhwal -- merging to get this into the 58.1.0 release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
unshred_variantsupport forBinaryandLargeBinarytypes #9526Rationale for this change
shred_variantalready supports Binary and LargeBinary types (#9525, #9554), but unshred_variant does not handle these types. This means shredded Binary/LargeBinary columns cannot be converted back to unshredded VariantArrays.What changes are included in this PR?
Adds unshred_variant support for DataType::Binary and DataType::LargeBinary in parquet-variant-compute/src/unshred_variant.rs:
Are these changes tested?
Yes
Are there any user-facing changes?
No breaking changes