chore: extend record_batch macro to support variables and expressions#9522
Open
buraksenn wants to merge 2 commits intoapache:mainfrom
Open
chore: extend record_batch macro to support variables and expressions#9522buraksenn wants to merge 2 commits intoapache:mainfrom
buraksenn wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Currently record_batch! macro supports only literal values. In datafusion repository there is also a record_batch! macro that supports this.
apache/datafusion#13037 can be closed after Datafusion repository upgrades version
What changes are included in this PR?
Extend record_batch! macro to support datafusion equivalent added in:
Are these changes tested?
I've actually ported datafusion logic to here. I was not sure if it makes sense to add unit tests for this macro but I can if requested
Are there any user-facing changes?
No breaking changes to downstream since this only extends macro