Verify footer tags when reading encrypted Parquet files with plaintext footers#7459
Merged
alamb merged 9 commits intoapache:mainfrom May 7, 2025
Conversation
e7cef64 to
2ee3c82
Compare
adamreeve
reviewed
Apr 30, 2025
7d6d3f7 to
e15517f
Compare
adamreeve
reviewed
May 2, 2025
Co-authored-by: Adam Reeve <adreeve@gmail.com>
e15517f to
a00efec
Compare
Member
Author
|
@adamreeve I've addressed your feedback, do you think this is ready for a final pass by @alamb ? |
adamreeve
reviewed
May 6, 2025
Contributor
adamreeve
left a comment
There was a problem hiding this comment.
This is looking pretty good to me although I've got one further comment.
Co-authored-by: Adam Reeve <adreeve@gmail.com>
87097f5 to
e87ccff
Compare
Member
Author
alamb
approved these changes
May 7, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Looks reasonable to me -- thank you @rok and @adamreeve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
From #7255
Closes #7255.
Rationale for this change
This adds a mechanism that willl prevent tampering with metadata.
What changes are included in this PR?
This adds a read-time integrity verification of footer metadata of read file.
Are there any user-facing changes?
Users get an opaque integrity verification check by default (will throw if failed) and can choose to opt out by calling
FileDecryptionProperties::Builder::disable_footer_signature_verificationmethod.