Add test of out of order UploadPart #7047
Open
+35
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
added
the
development-process
alamb
approved these changes
Feb 1, 2025
| let fut1 = multipart_upload.put_part(part1.into()); | ||
| let fut2 = multipart_upload.put_part(part2.into()); | ||
| let fut3 = multipart_upload.put_part(part3.into()); | ||
| fut2.await.unwrap(); |
There was a problem hiding this comment.
I missed the out of order part of the first read of this PR. Maybe a comment would help:
Suggested change
| fut2.await.unwrap(); | |
| // note order is 2,3,1 , different than the parts were created in | |
| fut2.await.unwrap(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
There have been various rumblings about concurrency issues related to multipart upload, this is my unsuccessful attempt to create a reproducer.
What changes are included in this PR?
Are there any user-facing changes?