Skip to content

fix(arrow-schema): allow empty metadata value for UUID extension type #10001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
May 20, 2026
Merged

fix(arrow-schema): allow empty metadata value for UUID extension type #10001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions arrow-schema/src/extension/canonical/uuid.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,14 @@ impl ExtensionType for Uuid {
fn deserialize_metadata(metadata: Option<&str>) -> Result<Self::Metadata, ArrowError> {
metadata.map_or_else(
|| Ok(()),
|_| {
Err(ArrowError::InvalidArgumentError(
"Uuid extension type expects no metadata".to_owned(),
))
|v| {
if !v.is_empty() {
Err(ArrowError::InvalidArgumentError(
"Uuid extension type expects no metadata".to_owned(),
))
} else {
Ok(())
}
},
)
}
Expand Down Expand Up @@ -122,11 +126,28 @@ mod tests {
let field = Field::new("", DataType::FixedSizeBinary(16), false).with_metadata(
[
(EXTENSION_TYPE_NAME_KEY.to_owned(), Uuid::NAME.to_owned()),
(EXTENSION_TYPE_METADATA_KEY.to_owned(), "".to_owned()),
(
EXTENSION_TYPE_METADATA_KEY.to_owned(),
"unexpected".to_owned(),
),
]
.into_iter()
.collect(),
);
field.extension_type::<Uuid>();
}

#[test]
fn empty_metadata_string_is_treated_as_none() -> Result<(), ArrowError> {
let field = Field::new("", DataType::FixedSizeBinary(16), false).with_metadata(
[
(EXTENSION_TYPE_NAME_KEY.to_owned(), Uuid::NAME.to_owned()),
(EXTENSION_TYPE_METADATA_KEY.to_owned(), "".to_owned()),
]
.into_iter()
.collect(),
);
field.try_extension_type::<Uuid>()?;
Ok(())
}
}
Loading