chore(rust): bump edition to 2024, MSRV to 1.85, and update dependencies#4043
Open
if0ne wants to merge 6 commits intoapache:mainfrom
Open
chore(rust): bump edition to 2024, MSRV to 1.85, and update dependencies#4043if0ne wants to merge 6 commits intoapache:mainfrom
if0ne wants to merge 6 commits intoapache:mainfrom
Conversation
eitsupi
reviewed
Mar 4, 2026
rust/Cargo.toml
Outdated
| edition = "2021" | ||
| rust-version = "1.81" | ||
| edition = "2024" | ||
| rust-version = "1.88" |
Contributor
There was a problem hiding this comment.
Why choose 1.88?
The constraint by arrow seems to be 1.85.
apache/arrow-rs@9d0e8be
Contributor
Author
There was a problem hiding this comment.
Initially, I chose 1.88 because adbc_datafusion has an MSRV of 1.88, and the cargo check produced an error when the 1.85 toolchain was selected.
Contributor
|
I suppose some deprecation warnings can be removed. |
if0ne
changed the title
Signed-off-by: if0ne <pavel.agafonov.al@gmail.com>
Signed-off-by: if0ne <pavel.agafonov.al@gmail.com>
Signed-off-by: if0ne <pavel.agafonov.al@gmail.com>
if0ne
force-pushed
the
rust/bump-version
branch
from
8ea0a46 to
83cdac9
Compare
Signed-off-by: if0ne <pavel.agafonov.al@gmail.com>
Signed-off-by: if0ne <pavel.agafonov.al@gmail.com>
if0ne
force-pushed
the
rust/bump-version
branch
from
b928f15 to
ffabd02
Compare
Contributor
Author
Contributor
|
As I've already commented, if we raise the minimum version of arrow, I think we'll need to replace the deprecated function arrow-adbc/rust/core/src/schemas.rs Lines 36 to 37 in 003f5e6 |
Signed-off-by: if0ne <pavel.agafonov.al@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
>=53.1.0to>=58)