feat: extend chaitin-waf plugin functionalities #9945 #12029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlyHKafoury
commented
Mar 10, 2025
dosubot
bot
added
size:L
dosubot
bot
added
size:XL
|
@membphis I believe this is ready for review |
|
@moonming A gentle ping that this PR is ready for review |
Cool, I will review your PR, thanks for your contribution |
|
I will Fix linting issues |
Baoyuantop
reviewed
Mar 12, 2025
Co-authored-by: Baoyuan <[email protected]>
Co-authored-by: Baoyuan <[email protected]>
Co-authored-by: Baoyuan <[email protected]>
|
@Baoyuantop Thank you for your comments, I applied them |
Can you help fix the failed CI? If it's unstable, let us know and we'll re-run it. |
|
It is unstable I only accepted the documentation changes, please rerun the
failed items on the CI
Best Regards,
Aly Kafoury
…On Wed, Mar 12, 2025, 12:06 PM Baoyuan ***@***.***> wrote:
@Baoyuantop <https://github.com/Baoyuantop> Thank you for your comments,
I applied them
Can you help fix the failed CI? If it's unstable, let us know and we'll
re-run it.
—
Reply to this email directly, view it on GitHub
<#12029 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIKUBD3HCPUR45P5OPCGPWT2UABK7AVCNFSM6AAAAABYUVBUHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJXGMZTANBUGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: Baoyuantop]*Baoyuantop* left a comment (apache/apisix#12029)
<#12029 (comment)>
@Baoyuantop <https://github.com/Baoyuantop> Thank you for your comments,
I applied them
Can you help fix the failed CI? If it's unstable, let us know and we'll
re-run it.
—
Reply to this email directly, view it on GitHub
<#12029 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIKUBD3HCPUR45P5OPCGPWT2UABK7AVCNFSM6AAAAABYUVBUHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJXGMZTANBUGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@Baoyuantop A gentle reminder |
Baoyuantop
previously approved these changes
Mar 13, 2025
moonming
previously approved these changes
Mar 19, 2025
AlinsRan
reviewed
Mar 19, 2025
Co-authored-by: AlinsRan <[email protected]>
|
@AlinsRan @Baoyuantop @moonming @membphis I completed the latest requested changes, and the tests pass locally so please review and help run the CI tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed #9945
Checklist