feat: route detail, edit page #3009
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reams-detail-edit
SkyeYoung
requested review from
juzhiyuan,
bzp2010,
Baoyuantop,
LiteSun and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR implements route detail and edit pages with updated plugins-related components and API integrations. Key changes include:
- Adding a new produceTime function and incorporating it into the production chain for data cleaning.
- Updating route components to use unified page button components (ToDetailPageBtn and ToAddPageBtn).
- Introducing the new route detail/edit page with form handling and API updates for route detail retrieval and submission.
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils/producer.ts | Updated pipeProduce to include produceTime in the production chain. |
| src/utils/form-producer.ts | Added produceTime to remove time-related properties from API responses. |
| src/routes/upstreams/index.tsx | Replaced custom detail button with ToDetailPageBtn for consistency. |
| src/routes/routes/index.tsx | Updated action column to use ToDetailPageBtn, and adjusted imports. |
| src/routes/routes/detail.$id.tsx | Introduced route detail/edit form with react-hook-form and mutation handling. |
| src/routes/protos/index.tsx & global_rules/index.tsx | Adjusted imports of page button components. |
| src/components/page/ToAddPageBtn.tsx | Refactored ToAddPageBtn and added ToDetailPageBtn for route navigation. |
| src/components/form-slice/FormItemPlugins/* | Updated plugin components to use Drawer.Stack and support a disabled state. |
| src/apis/routes.ts | Added new API functions (getRouteQueryOptions and putRouteReq) for route detail handling. |
Files not reviewed (1)
- src/locales/en/common.json: Language not supported
Comments suppressed due to low confidence (2)
src/components/form-slice/FormItemPlugins/index.tsx:116
- [nitpick] Confirm that wrapping the plugin components within Drawer.Stack aligns with the design system and responsive layout requirements. It would be beneficial to document any design assumptions regarding this UI structure.
<Drawer.Stack>
src/components/page/ToAddPageBtn.tsx:10
- Ensure that using 'keyof FilterKeys<FileRoutesByTo, "add">' for the 'to' prop is consistently applied across the routing components and accurately restricts the valid route keys. Verify that this type change propagates correctly to prevent route mismatches.
to: keyof FilterKeys<FileRoutesByTo, 'add'>;
bzp2010
reviewed
Apr 30, 2025
src/routes/routes/detail.$id.tsx
Outdated
| disabled: readOnly, | ||
| }); | ||
|
|
||
| // 将API数据加载到表单中 |
There was a problem hiding this comment.
remove comments in chinese
src/routes/routes/detail.$id.tsx
Outdated
| } | ||
| }, [routeData, form, isLoading]); | ||
|
|
||
| // 处理表单提交和路由更新 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
route detail, edit page, with plugins related components fixed.