feat: protos page, FileUploadTextarea component #3001
Merged
+642
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkyeYoung
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR implements the new protos pages and a FileUploadTextarea component to support upcoming feature work. Key changes include:
- Adding new routes and pages for the protos list, detail, and creation.
- Extending the schema types and request constants to support protos.
- Introducing the FileUploadTextarea component for file upload handling in forms.
Reviewed Changes
Copilot reviewed 19 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/types/schema/apisix/index.ts | Includes new A6Proto type and spreads it into the A6 object. |
| src/types/schema/apisix/common.ts | Introduces Timestamp and Info schemas for common metadata. |
| src/routes/protos/*.tsx | Implements new protos listing, detail, and add routes. |
| src/routeTree.gen.ts | Updates route definitions to integrate the new protos routes. |
| src/config/req.ts | Adds interceptor logic to normalize empty list responses. |
| src/components/form/FileUploadTextarea.tsx | Introduces a new file upload textarea component with file error handling. |
| Other files | Minor updates (e.g., removal of unused imports, nav route update). |
Files not reviewed (3)
- package.json: Language not supported
- pnpm-lock.yaml: Language not supported
- src/locales/en/common.json: Language not supported
Comments suppressed due to low confidence (1)
src/routeTree.gen.ts:161
- [nitpick] There is a slight inconsistency in the use of trailing slashes for protos routes (e.g., '/protos' vs '/protos/'). Consider standardizing these definitions across FileRoutesByFullPath and FileRoutesById to avoid potential routing ambiguities.
'/protos/': {
Baoyuantop
approved these changes
Apr 27, 2025
bzp2010
reviewed
Apr 27, 2025
LiteSun
reviewed
Apr 27, 2025
| @@ -0,0 +1,69 @@ | |||
| import { useEffect } from 'react'; | |||
There was a problem hiding this comment.
There are no relevant rules, and add them to the subsequent PR.
LiteSun
approved these changes
Apr 27, 2025
bzp2010
approved these changes
Apr 27, 2025
This was referenced Apr 27, 2025
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Part of #3000.
Because I need FileUploadTextarea component in next PRs. Also add protos detail page, list page for testing.