Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need more language support #1407 #2924

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gauravs1018
Copy link

Issue

Resolves #1407

Summary

This merge request addresses the internationalization (i18n) enhancement request to add Hindi language support to APISIX Dashboard.

Changes Made

  1. Global Locales: Added Hindi translations to the global locales file located at src/locales.
  2. Page-Specific Locales: Modified the Hindi translations for each page in their respective locale files under src/pages/$PAGE/locales.
  3. Component-Specific Locales: Updated the Component's locale file with Hindi translations under src/components/$COMPONENT/locales.

Implementation Details

Utilized key-based translation for consistency across all locales.

Additional Notes:

Please review and provide feedback on the implementation of Hindi language support.
Ensure that the changes align with the project's coding standards and best practices.

Reference:

Utilized guidelines from User Guide for making these changes.

Conclusion

This merge request contributes to enhancing the APISIX Dashboard's internationalization capabilities, specifically by introducing Hindi language support. The changes are comprehensive.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad697c6) 69.08% compared to head (f691e8e) 69.03%.

❗ Current head f691e8e differs from pull request most recent head 7d2e4c3. Consider uploading reports for the commit 7d2e4c3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2924      +/-   ##
==========================================
- Coverage   69.08%   69.03%   -0.06%     
==========================================
  Files         139      139              
  Lines        3746     3746              
  Branches      881      881              
==========================================
- Hits         2588     2586       -2     
- Misses       1158     1160       +2     
Flag Coverage Δ
frontend-e2e-test 69.03% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n: Need more language support
3 participants