Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset submit status when upstream data invalid #2867

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZhangShangyu
Copy link

@ZhangShangyu ZhangShangyu commented Oct 12, 2023

When the upstream data is invalid, click submit button will notice error, but the submit button still show loading, user can not resubmit after correct the data. So it needs to reset loading after notice error.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Create or update upstream with invalid data, the frontend will notice error and reset submit loading status.

Related issues

NA

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@ZhangShangyu ZhangShangyu changed the title reset submit status when upstream data invalid fix: reset submit status when upstream data invalid Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant