-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to use env variables in config #2819
base: master
Are you sure you want to change the base?
feat: allow to use env variables in config #2819
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2819 +/- ##
==========================================
- Coverage 77.49% 74.65% -2.84%
==========================================
Files 139 201 +62
Lines 3746 7860 +4114
Branches 881 881
==========================================
+ Hits 2903 5868 +2965
- Misses 843 1681 +838
- Partials 0 311 +311
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 62 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@Gallardot fixed the failing unit test, please approve workflow execution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@juzhiyuan @bzp2010 @guoqqqi Sorry guys, can we proceed with this feature? Your reviews are very desired, thanks. |
@juzhiyuan @bzp2010 @guoqqqi up for review, thanks |
Hello, I personally not available those months. |
@bzp2010 @Baoyuantop hi, hope you will be able to check proposed changes, thanks |
Why submit this pull request?
What changes will this PR take into?
This ticket adds an ability to use environment variables in the dashboard configuration using viper decode hooks. Such change is required to simplify dashboard configuration based on the environment type. For example can be useful to provide dashboard users and their passwords.
Related issues
#2818
Checklist: