Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Refactored MemorySizeTest.testUnitConversion to Parameterized Test #3450

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+22 −36
Open

[Improvement]: Refactored MemorySizeTest.testUnitConversion to Parameterized Test #3450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 22 additions & 36 deletions amoro-common/src/test/java/org/apache/amoro/utils/MemorySizeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,46 +26,32 @@
import static org.junit.Assert.fail;

import org.junit.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;

import java.util.stream.Stream;

/** Tests for the {@link MemorySize} class. */
public class MemorySizeTest {

@Test
public void testUnitConversion() {
final MemorySize zero = MemorySize.ZERO;
assertEquals(0, zero.getBytes());
assertEquals(0, zero.getKibiBytes());
assertEquals(0, zero.getMebiBytes());
assertEquals(0, zero.getGibiBytes());
assertEquals(0, zero.getTebiBytes());

final MemorySize bytes = new MemorySize(955);
assertEquals(955, bytes.getBytes());
assertEquals(0, bytes.getKibiBytes());
assertEquals(0, bytes.getMebiBytes());
assertEquals(0, bytes.getGibiBytes());
assertEquals(0, bytes.getTebiBytes());

final MemorySize kilos = new MemorySize(18500);
assertEquals(18500, kilos.getBytes());
assertEquals(18, kilos.getKibiBytes());
assertEquals(0, kilos.getMebiBytes());
assertEquals(0, kilos.getGibiBytes());
assertEquals(0, kilos.getTebiBytes());

final MemorySize megas = new MemorySize(15 * 1024 * 1024);
assertEquals(15_728_640, megas.getBytes());
assertEquals(15_360, megas.getKibiBytes());
assertEquals(15, megas.getMebiBytes());
assertEquals(0, megas.getGibiBytes());
assertEquals(0, megas.getTebiBytes());

final MemorySize teras = new MemorySize(2L * 1024 * 1024 * 1024 * 1024 + 10);
assertEquals(2199023255562L, teras.getBytes());
assertEquals(2147483648L, teras.getKibiBytes());
assertEquals(2097152, teras.getMebiBytes());
assertEquals(2048, teras.getGibiBytes());
assertEquals(2, teras.getTebiBytes());
static Stream<Object[]> memorySizeProvider() {
return Stream.of(
new Object[]{MemorySize.ZERO, 0, 0, 0, 0, 0},
new Object[]{new MemorySize(955), 955, 0, 0, 0, 0},
new Object[]{new MemorySize(18500), 18500, 18, 0, 0, 0},
new Object[]{new MemorySize(15 * 1024 * 1024), 15_728_640, 15_360, 15, 0, 0},
new Object[]{new MemorySize(2L * 1024 * 1024 * 1024 * 1024 + 10), 2199023255562L, 2147483648L, 2097152, 2048, 2}
);
}

@ParameterizedTest
@MethodSource("memorySizeProvider")
void testUnitConversion(MemorySize memorySize, long expectedBytes, long expectedKibiBytes, long expectedMebiBytes, long expectedGibiBytes, long expectedTebiBytes) {
assertEquals(expectedBytes, memorySize.getBytes());
assertEquals(expectedKibiBytes, memorySize.getKibiBytes());
assertEquals(expectedMebiBytes, memorySize.getMebiBytes());
assertEquals(expectedGibiBytes, memorySize.getGibiBytes());
assertEquals(expectedTebiBytes, memorySize.getTebiBytes());
}

@Test(expected = IllegalArgumentException.class)
Expand Down