Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3424] Add the self-optimizing.partition-filter parameter #3426

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lintingbin
Copy link
Contributor

Why are the changes needed?

Close #3424 .

Brief change log

  • Add the self-optimizing.partition-filter parameter.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs

@lintingbin
Copy link
Contributor Author

Here is my current simple implementation code. Please provide some feedback, and I will continue to improve it.

@zhoujinsong
Copy link
Contributor

Thanks for the contribution!

The Spark core is a somewhat heavy lib to add to the common module.
JSqlParser is a lightweight lib to parse SQL, it may help.

@lintingbin
Copy link
Contributor Author

Thanks for the contribution!

The Spark core is a somewhat heavy lib to add to the common module. JSqlParser is a lightweight lib to parse SQL, it may help.

Okay, I'll research JSqlParser.

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 3.77358% with 51 lines in your changes missing coverage. Please review.

Project coverage is 27.78%. Comparing base (decd55d) to head (6d254a9).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...o/optimizing/plan/AbstractOptimizingEvaluator.java 0.00% 45 Missing ⚠️
...java/org/apache/amoro/config/OptimizingConfig.java 0.00% 5 Missing ⚠️
...n/java/org/apache/amoro/table/TableProperties.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3426      +/-   ##
============================================
+ Coverage     21.64%   27.78%   +6.14%     
- Complexity     2316     3591    +1275     
============================================
  Files           427      599     +172     
  Lines         39751    48661    +8910     
  Branches       5630     6277     +647     
============================================
+ Hits           8605    13522    +4917     
- Misses        30419    34199    +3780     
- Partials        727      940     +213     
Flag Coverage Δ
core 27.78% <3.77%> (?)
trino ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Feb 18, 2025
@lintingbin lintingbin changed the title feature: Add the self-optimizing.partition-filter parameter [AMORO-3424] Add the self-optimizing.partition-filter parameter Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module module:common type:build type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add the self-optimizing.partition-filter parameter.
4 participants