-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-3424] Add the self-optimizing.partition-filter parameter #3426
base: master
Are you sure you want to change the base?
Conversation
Here is my current simple implementation code. Please provide some feedback, and I will continue to improve it. |
Thanks for the contribution! The Spark core is a somewhat heavy lib to add to the common module. |
Okay, I'll research JSqlParser. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3426 +/- ##
============================================
+ Coverage 21.64% 27.78% +6.14%
- Complexity 2316 3591 +1275
============================================
Files 427 599 +172
Lines 39751 48661 +8910
Branches 5630 6277 +647
============================================
+ Hits 8605 13522 +4917
- Misses 30419 34199 +3780
- Partials 727 940 +213
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Why are the changes needed?
Close #3424 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation