created a new folder named ambari-web-vite#3931
Open
81163954 wants to merge 3 commits intoapache:trunkfrom
Open
created a new folder named ambari-web-vite#393181163954 wants to merge 3 commits intoapache:trunkfrom
81163954 wants to merge 3 commits intoapache:trunkfrom
Conversation
Contributor
|
@zRains Could you help review this? |
Contributor
|
Thanks for your work and for providing a solid idea for developing ambari-web. However, IMO, what we need is a simple proxy server. For Vite, the ideal choice should be node-http-proxy. But in your code, you've included the initialization of a Vite project, and some of the resources there won’t actually be used—like the CSS files. This kind of separated development environment increases debugging costs, so it’s more suitable for early, non-optimized DEV. Later on, I’d recommend replacing Brunch with Vite. This way, we can make better use of Vite’s features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Created a new folder named ambari-web-vite in ambari-web,The goal is to use Vite to proxy Ambari Web.
The process is as follows: First, use Brunch to build the public folder in Ambari Web, and then use Vite to directly start the Ambari Web project in ambari-web-vite.