fix: remove redundant columns in XCom panel on task instance page#68188
Open
anmolxlight wants to merge 3 commits into
Open
fix: remove redundant columns in XCom panel on task instance page#68188anmolxlight wants to merge 3 commits into
anmolxlight wants to merge 3 commits into
Conversation
Closes apache#68178 When viewing XCom entries from the task instance (Grid view), the 'Dag ID', 'Dag Run ID', 'Run After', 'Task', and 'Map Index' columns are redundant because this information is already visible in the header. Hide these columns specifically in that context while keeping them on the global Browse > XCom page where they provide necessary context.
anmolxlight
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When viewing XCom entries from the Grid view (task instance context), the following columns are redundant because the same information is already visible in the header above:
These columns are now conditionally rendered — hidden on the task instance detail page (Grid view XCom tab) while still shown on the global Browse > XCom page where they provide necessary context.
How
Added an
isTaskInstancePagecheck (derived from URL params) and conditionally spreads the redundant column definitions only when viewing from the global XCom page.Closes #68178
(cherry-picked from 7e6818f)