[v3-2-test] Fix CronMixin in task-sdk not resolving cron presets before validation (#66102)#68187
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[v3-2-test] Fix CronMixin in task-sdk not resolving cron presets before validation (#66102)#68187github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…re validation (#66102) * Fix CronMixin not resolving cron presets before validation * Fix ruff: use tuple for pytest.mark.parametrize first argument * Address review: add sync comment, explain post_init, static test table, add timetable test * Make airflow-core re-export CRON_PRESETS from SDK as single source of truth * Fix ruff removing re-export import by adding noqa: F401 * Revert re-export: restore cron_presets dict in core, add sync comments * Move timetable tests to timetables/test__cron.py to match module structure --------- (cherry picked from commit 4b40714) Co-authored-by: Shashwati Bhattacharyaa <166847329+shashbha14@users.noreply.github.com> Co-authored-by: Shashwati <shashwatibhattacaharya21.2@gmail.com>
Contributor
|
Keeping as draft to save CI resources and assuming no 3.2. release cut. Else could be merged there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CronMixin not resolving cron presets before validation
Fix ruff: use tuple for pytest.mark.parametrize first argument
Address review: add sync comment, explain post_init, static test table, add timetable test
Make airflow-core re-export CRON_PRESETS from SDK as single source of truth
Fix ruff removing re-export import by adding noqa: F401
Revert re-export: restore cron_presets dict in core, add sync comments
Move timetable tests to timetables/test__cron.py to match module structure
(cherry picked from commit 4b40714)
Co-authored-by: Shashwati Bhattacharyaa 166847329+shashbha14@users.noreply.github.com
Co-authored-by: Shashwati shashwatibhattacaharya21.2@gmail.com