feat(graph): add basic "Rearrange" mode for Dag graph view#68171
Open
TomasCorreia2003 wants to merge 1 commit into
Open
feat(graph): add basic "Rearrange" mode for Dag graph view#68171TomasCorreia2003 wants to merge 1 commit into
TomasCorreia2003 wants to merge 1 commit into
Conversation
Adds ability to drag and drop nodes in Dag graph view. Adds node collision avoidance and edge rerouting for "Rearrange" mode. When leaving graph view or toggling "Rearrange" off, the graph returns to its previous unaltered state. Closes apache#55796 Co-authored-by: Bernardo Borges de Sousa <bernardogbsousa2@tecnico.ulisboa.pt>
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Member
|
Could you attach before/after screenshots or a short recording for this UI change? |
Contributor
|
Echoing @choo121600, a GIF would also be very helpful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature addresses #55796 by adding a "Rearrange" button which when pressed, allows users to drag and drop nodes when in a DAG's graph view. For this, it adds node collision-avoidance on node drop and real-time edge recalculation to provide users with a responsive and helpful experience. Users cannot control edges as they represent dependencies. We also decided to make any changes while in "Rearrange mode" not persistent as the feature is simply meant to be a viewing aid for confusing graphs such as the ones spawned from complex DAGs.
This will be a great start for anyone attempting to make this mode persistent or any other QoL or functional improvements.
Closes #55796