Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,27 @@ def test_get_pool3_should_respond_200(self, test_client, session):
"team_name": None,
}

def test_get_unlimited_pool_should_respond_200(self, test_client, session):
"""Regression for #65377: an unlimited (-1 slots) pool has open_slots == inf internally; the
response must serialize open_slots as -1 and return 200, not 500."""
session.add(Pool(pool="unlimited_pool", slots=-1, include_deferred=False))
session.commit()
response = test_client.get("/pools/unlimited_pool")
assert response.status_code == 200
assert response.json() == {
"deferred_slots": 0,
"description": None,
"include_deferred": False,
"name": "unlimited_pool",
"occupied_slots": 0,
"open_slots": -1,
"queued_slots": 0,
"running_slots": 0,
"scheduled_slots": 0,
"slots": -1,
"team_name": None,
}


class TestGetPools(TestPoolsEndpoint):
@pytest.mark.parametrize(
Expand Down Expand Up @@ -238,6 +259,17 @@ def test_should_call_get_authorized_pools(self, mock_get_authorized_pools, test_
assert body["total_entries"] == 2
assert [pool["name"] for pool in body["pools"]] == [Pool.DEFAULT_POOL_NAME, POOL1_NAME]

def test_get_pools_with_unlimited_pool_should_respond_200(self, test_client, session):
"""Regression for #65377: listing pools that include an unlimited (-1 slots) pool must serialize
open_slots as -1 through the collection serializer and return 200, not 500."""
session.add(Pool(pool="unlimited_pool", slots=-1, include_deferred=False))
session.commit()
response = test_client.get("/pools")
assert response.status_code == 200
pools = {pool["name"]: pool for pool in response.json()["pools"]}
assert pools["unlimited_pool"]["slots"] == -1
assert pools["unlimited_pool"]["open_slots"] == -1


class TestPatchPool(TestPoolsEndpoint):
@pytest.mark.parametrize(
Expand Down
Loading