Fix "Trigger again with this config" ignoring param changes made in the UI#67253
Fix "Trigger again with this config" ignoring param changes made in the UI#67253shashbha14 wants to merge 4 commits into
Conversation
584b564 to
13c28ef
Compare
|
@shashbha14 — There are 1 unresolved review thread(s) on this PR from Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting |
|
@shashbha14 A few things need addressing before review — see our Pull Request quality criteria.
No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
|
@shashbha14 A few things need addressing before review — see our Pull Request quality criteria.
No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
Closes #67243
When using "Trigger again with this config", any changes made to params in the trigger form were ignored and the original conf from the previous run was submitted instead.
The useEffect that syncs the param store's conf back into the form field had a
!prefillConfigguard, which blocked it from running when "Trigger again" was used. So editing a param via the UI updated the store but the form field stayed on the original value.Removed the guard so the form always stays in sync with the store, and removed prefillConfig from the dependency array since it is no longer used inside that effect.