Skip to content

Conversation

@nhuantho
Copy link
Contributor

@nhuantho nhuantho commented Jan 5, 2026

Why:

How

  • Remove dags update test

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@nhuantho nhuantho changed the title Remove dags update Remove dags update testing Jan 5, 2026
@nhuantho nhuantho force-pushed the fix-airflow-ctl-integration-tests branch from caf5de7 to 774f860 Compare January 5, 2026 17:17
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @bugraoz93

The docs you mentioned are of Airflow CLI whereas the tests is for AirflowCTL.

I don't understand the rationale of this change

Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Kaxil. The path you have checked is Airflow CLI, not airflowctl. That's why you shouldn't be able to find it. You should check airflow-ctl/src/airflowctl/ctl/commands/*.py or in airflow-ctl/src/airflowctl/api/operations.py as a method.

I have checked the linked PR and see that your job is failing on dagrun get now in your latest push. I believe some things were failing differently, and maybe for different reasons
Current latest: https://github.com/apache/airflow/actions/runs/20723278190/job/59494786645?pr=60135

We shouldn't delete any command from here unless it's both deprecated and removed. You won't be able to make these changes because we have a prek hook that checks if any implemented or changed commands in airflowctl are in integration tests. What we should do is find the main reason why the failure is and fix that either in airflowctl or in the API, according to where the problem lives

@nhuantho
Copy link
Contributor Author

nhuantho commented Jan 6, 2026

@kaxil @bugraoz93 thanks for review. I had a mix-up and I’m re-check.

@bugraoz93
Copy link
Contributor

Thanks again for the PR! Closing this for now to clean up the backlog to help maintainers to. Feel free to create a follow-up PR. We haven't found the reason yet, but we saw this in CI failures. We will solve it by adding a retry mechanism, such as in TaskSDK or in Edge

@bugraoz93 bugraoz93 closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants