Skip to content

Conversation

@kishorek07
Copy link

Problem

When using an external PostgreSQL instance and setting postgresql.enabled=false in values.yaml, the Airflow Helm chart still renders and deploys PostgreSQL-related resources such as:

  • Migration jobs
  • Helm hooks (pre-install, post-upgrade)
  • Cleanup jobs

This causes errors during deployment and breaks compatibility with external PostgreSQL setups.

Solution

Wrapped PostgreSQL-specific templates with a conditional check:

  • if .Values.postgresql.enabled
    • PostgreSQL-related Job / Hook definitions
  • end

This ensures PostgreSQL hooks and jobs are skipped when PostgreSQL is disabled.

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 4, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@jedcunningham
Copy link
Member

jedcunningham commented Jan 5, 2026

Closing. There are no changes in this PR.

Though, the hooks/jobs intentionally run even with an external postgres instance. Not opposed to having a way to disable them, but it cannot be that config option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants