Skip to content

Conversation

@Divyaselva14
Copy link

This PR migrates the edge3 provider to import conf from the common compat module instead of directly from airflow.configuration, ensuring compatibility across Airflow 2.11+ and 3.0+.

Changes

Updated import statements from from airflow.configuration import conf to from airflow.providers.common.compat.sdk import conf

Related: #60000


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@Divyaselva14 Divyaselva14 requested a review from jscheffl as a code owner January 4, 2026 06:16
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 4, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added area:providers provider:edge Edge Executor / Worker (AIP-69) / edge3 labels Jan 4, 2026
@Prab-27
Copy link
Contributor

Prab-27 commented Jan 4, 2026

what if we also update pyproject.toml, since it also has dependencies such as

"apache-airflow-providers-common-compat>=1.10.1",

as issue describes ?

@potiuk
Copy link
Member

potiuk commented Jan 4, 2026

There are some errors in tests -> i guess adding defaults in tests is needed. It happened in one of the related PRs.

@Divyaselva14
Copy link
Author

Hi @potiuk , Tests fail because

(https://github.com/apache/airflow/blob/960c2c5d6cb0e731e1b76f498abe1f11a224d4c3/providers/edge3/tests/unit/edge3/executors/test_edge_executor.py#L64C8-L64C86)` raises “section/key not found”, even though the provider defines a default.

What is the correct pattern in providers to safely read provider config defaults in unit tests?

@potiuk
Copy link
Member

potiuk commented Jan 5, 2026

What is the correct pattern in providers to safely read provider config defaults in unit tests?

It seems we are currently missing this functionality in the new conf. We have been discussing it in the cncf.kubernetes conf PR #60074 (comment) -> and I think we will get it implemented there as a generic feature that you will be able to reuse here. So I guess good idea for you is to read what we proposed there and possibly review/participate in implementation (and then rebase when we merge the implementation and apply it here).

@Divyaselva14 Divyaselva14 force-pushed the migrate-edge3-conf-import branch from bbfe3be to ecbd5de Compare January 8, 2026 16:05
Copy link
Member

@dheerajturaga dheerajturaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uranusjr
Copy link
Member

uranusjr commented Jan 9, 2026

Tests are failing

@sunank200
Copy link
Collaborator

@Divyaselva14, overall, the changes look good, but the test seems to be failing.

@Divyaselva14 Divyaselva14 force-pushed the migrate-edge3-conf-import branch from ecbd5de to be988f5 Compare January 15, 2026 11:02
@Divyaselva14
Copy link
Author

@sunank200 , I have rebased but tried adding fallbacks. I am looking into this approach [60074#issuecomment]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:edge Edge Executor / Worker (AIP-69) / edge3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants