-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart: add OpenSearch remote logging options #45082
Open
topherinternational
wants to merge
21
commits into
apache:main
Choose a base branch
from
topherinternational:opensearch-chart-option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chart: add OpenSearch remote logging options #45082
topherinternational
wants to merge
21
commits into
apache:main
from
topherinternational:opensearch-chart-option
+659
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topherinternational
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
December 19, 2024 16:25
topherinternational
force-pushed
the
opensearch-chart-option
branch
from
December 19, 2024 16:30
cd3bfd0
to
16d04c5
Compare
topherinternational
force-pushed
the
opensearch-chart-option
branch
from
December 20, 2024 03:06
16d04c5
to
b54829e
Compare
topherinternational
force-pushed
the
opensearch-chart-option
branch
from
December 20, 2024 03:38
df90bba
to
5435776
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change duplicates the existing elasticsearch configurations to support the new OpenSearch remote logging option added in #41799.
In addition to adding the
opensearch
block invalues.yaml
, it also adds a disambiguation check to prevent users from enabling both Elasticsearch and openSearch remote logging, as Airflow does not support using both at the same time.Finally, a suite of tests is added to test the existing Elasticsearch configuration options as well as the new OpenSearch options. A few existing tests have been moved to put all of the ES/OS/remote logging behaviors under a single test module.