Skip to content

Commit

Permalink
Sort "opts" element in click option dictionary before hashing (#45156)
Browse files Browse the repository at this point in the history
Some impleemntation details of click 8.1.8 caused instability in
configuration directories that are produced by click config - the
instability is in sequence of generated "opts" list - the sequence
of options in it is random.

While it can be likely fixed in later versions, better is to
protect from it and sort the opts list before hashing the dict.
  • Loading branch information
potiuk authored Dec 22, 2024
1 parent cf401c4 commit 1796c40
Show file tree
Hide file tree
Showing 81 changed files with 410 additions and 364 deletions.
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_build-docs.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
b349182dab04b6ff58acd122a403a5a4
16278718c7278a46f343ae5a64a9ae21
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_ci-image_build.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
b03ca6dcb44ef05f9c27f72318ff9500
60e01048b3af164825f8ec4070543e89
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_ci-image_pull.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
eadf5c7b6661cf557c2ab5b38e462481
a2b4311906864d2e22049bf37c1b6b64
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_ci-image_verify.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
324f4d4949eef209e991d890ddf2ff4f
d4747f6b4f6d78a8eeced35475ed91f0
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_ci_fix-ownership.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3e5a73533cc96045e72cb258783cfc96
9decf6bb3eecbe566006f39f22cb331a
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_ci_free-space.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
49af17b032039c05c41a7a8283f365cc
21f9955c2f47b4524f1df73af8594d54
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_ci_resource-check.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
bfcca92f18a403ca630955074eb5e9ad
858a3c3a7f47ab6b47364a9fff1c19ac
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_ci_selective-check.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6657ed5d42affb7264b5efcc86f17a2a
78d4ac07ec90efce5bd901f461d940bc
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_cleanup.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
231de69d5f47ba29c883164e4575e310
45d1ac665d85bff99d1ea396be00f892
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_compile-ui-assets.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
a3230118e8ad9cd73c9b67acaf77c994
92830a5b5f1afbbd42017e2e4b7b2dbb
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_compile-www-assets.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2c65b08cbff1b5be5b5c55fcd18580a9
5b57c7464757837e78ed9ad7e2b39d6b
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_down.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
65834d56aa23a727a3b5a5c6f8197400
17e350cf4ddd966bc9aa142d5452317c
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_exec.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
42bbd3c1659128b0341ae118c3482da2
300c15ecdfffbb85926ab31fc775521a
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_generate-migration-file.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
747d68bcaed5decfa6da146eb9c74e64
fe2f7beb040bd87d2ba9ec143c067711
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_k8s_build-k8s-image.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7e4553f3179fe40e5c05bfc556cb2355
23407b52a0d231586a557bfb3a62cf56
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_k8s_configure-cluster.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6e0e5ed30fcde18abe30f7dab1c4f0b6
c6b00a3e29661e7da1b4f31ec8059f9c
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_k8s_create-cluster.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
254a3805eeb108125d078abecf9226fb
db5457f7b24c460af060fd0570cf6540
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_k8s_delete-cluster.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
11cd0c89e39c35786fb33d00fbb927fc
4858df418c00c6f7610a8b6c5712dc21
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_k8s_deploy-airflow.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5b0897a8784fd3ef29cf789e10507936
e76733e85aa4515c885e1545d23a808b
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_k8s_k9s.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4330a248804808ca67646fd429521ea4
987bac06ce9be77bb97a2e3edeed41ec
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_k8s_logs.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
109337ad03745a9ee525cc5c88b44965
681859603186949ed61bbc30fbcc11ff
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_k8s_run-complete-tests.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
e90124f34ca3e3048003f30dcb4726a6
8a9d77567085d89265fc52eb77932731
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_k8s_setup-env.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
a34e94744ca4e0592371fe55478c3d54
519e87a2048c3f841196e43a09f183f6
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_k8s_shell.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
e4d387e242567191bd381fffbe949b57
e85c5d5b7be263ab98e2fac81ce70d86
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_k8s_status.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8d422180eade6405e3bb880496242aaa
a48ee98548f41870849af461a5679f91
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_k8s_tests.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ed1e0a02b7f38a9cdd8810b70fd350d3
17965ece7bd99cae183a3610ff03e7be
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_k8s_upload-k8s-image.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
774439a1c9e22923f9ace56902c41dcd
069265058f363e5e2f5ab7ff53ded033
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_prod-image_build.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3576058438d009eb3dc8be53ea16be8a
46a046cb3b7ba63753bbc61410d4d8d3
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_prod-image_pull.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
54188d6d9544b2bd4cc9b77f55a34565
55b7b67b36baabc8067c3453549bde75
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_prod-image_verify.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1c833a3c2dcde9f9edf165a958fccb47
476434f4359f3e4e12b76ff55f4ba2f5
Original file line number Diff line number Diff line change
@@ -1 +1 @@
33a9bed85312c80e1464318d1aaa5632
03f7d04a09488fcd7c28c13d0653ff7e
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16862ea6a616ef66a192424838062813
085dfd3570b78ad1be8dd95f480be582
Original file line number Diff line number Diff line change
@@ -1 +1 @@
a3834afc4aa5d1e98002c9e9e7a9931d
5b63e90b9597e5a47cc4fbfa32ab9fbe
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ac54d7c8e352e6012280df2649354c3b
74e78d80f0339f8069039fa95479ec2a
Original file line number Diff line number Diff line change
@@ -1 +1 @@
15723131610a3be9a3093f346e72ed06
00382e6b2a84a1edbf77eb5ed0a9df72
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3e0e080fa8422853ed7df3967725b35f
798f6631dad1b650e8a48fa5d51d73e6
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1 +1 @@
28d0c552a4f581e0541835944c72498e
d268aa8d56617f065ff8049e37ac60f9
Original file line number Diff line number Diff line change
@@ -1 +1 @@
d1eb314d4c9e949306d06f079a1463e5
fe93d72f5d749f318b0a13294ea95d08
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8c3be9f78286641f5657f890745ef936
27169c83fcbcca907a0b32a5c4faeb48
Original file line number Diff line number Diff line change
@@ -1 +1 @@
d57dc8d296addbea3fd3285e2063c102
15c3eb3be97998320dc95431840d8b3a
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1baef77ed7f5328a75248bb91a2d3a11
07b221762eed9e3344466b445ca6668b
Original file line number Diff line number Diff line change
@@ -1 +1 @@
85b9590e16c1986679675b5e605844da
bb317d3fef1d85908c6ffa160924d36a
Original file line number Diff line number Diff line change
@@ -1 +1 @@
aa5da16329704d537cf3c6d6f38ab8d9
2a24df4fb60b12ac81b2fcbe151c1f8d
Original file line number Diff line number Diff line change
@@ -1 +1 @@
adc65fd78e7040d42660aea2289d0f96
075bd419e0ceac06d78c39361cb999fe
Original file line number Diff line number Diff line change
@@ -1 +1 @@
71bdb81ad79b6f928c0324d9f39af6ae
c9f176661908b6f7fc5795ceaedfa5e1
Original file line number Diff line number Diff line change
@@ -1 +1 @@
88257fc6d1b13061b19f0a623183c1c1
288240b459768445e398365736594161
Original file line number Diff line number Diff line change
@@ -1 +1 @@
b27bd524dd3c89f50a747b60a7e892c1
e75bc9b0750c67b82bb1cf41b6cb0ccd
Original file line number Diff line number Diff line change
@@ -1 +1 @@
419f48f6a4ff4457cb9de7ff496aebbe
495a5e3d024bc6039290d9f4528a3ca4
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7c32e47c0359fa185ab30ed5fc4c91cf
403dae670f839e37c83baa15ac65af9a
Original file line number Diff line number Diff line change
@@ -1 +1 @@
02ec4b119150e3fdbac52026e94820ef
cd4df9af29227f6de406050fbb12dd3b
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1 +1 @@
627539a2eca6bbf7f261697db125f983
e00b5b4f0bb6e565595f862730c43275
Original file line number Diff line number Diff line change
@@ -1 +1 @@
fbf15f8f21cdda9f815a801d9e266b61
24b1be5f59a0d7db2bac65edbdb693a1
Original file line number Diff line number Diff line change
@@ -1 +1 @@
dae379c46a11a46a2cef916899fea34f
432576382063ad0f8e30e277713bbc10
Original file line number Diff line number Diff line change
@@ -1 +1 @@
898569c394d60dbb021f0599b9fb7c82
c77360bfe9bd3d86bfc4e6a763969fb6
Original file line number Diff line number Diff line change
@@ -1 +1 @@
116a44d6ee103f8b57ce56a3e774c70b
60ea5de9051747f494fe1d40310fba85
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_setup.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ea2ff499fd3c25ef89abaab313d5d04a
ba00ab3fb2ed5a777684878c28b3ce65
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_setup_autocomplete.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ec3b4541a478afe5cb86a6f1c48f50f5
3da8dc88411f34d3ed52c155df744c22
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4f2ddff749749897c4bdd3b36b5b3c32
c4fd2fc3abe08380651f5c165250d870
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_setup_config.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
77ef3d93e2fc477eb70928281e1f9ec6
44292b9abca625c3e2710b19e2f9bd74
Original file line number Diff line number Diff line change
@@ -1 +1 @@
9c3f87d890317e2fbd0ecc37be22ba4f
2e42a9de8b8ed2ce83b5a1fcbdaa0158
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_setup_self-upgrade.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4af905a147fcd6670a0e33d3d369a94b
9ad9de5cc99ce2133e14d7dc15c1042a
Original file line number Diff line number Diff line change
@@ -1 +1 @@
252c8ee48ca57e6539064544cbd63e58
85797323723a480a895251c1b6db9356
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_setup_version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
be116d90a21c2afe01087f7609774e1e
b41f292ef2af6d7988bedc6effd73263
Loading

0 comments on commit 1796c40

Please sign in to comment.