Release/1.1.0 #25
Merged
Release/1.1.0 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nceBulkDownloader - Updated `requests` to version 2.32.0 and `setuptools` to version 70.0.0 in `requirements.txt`. - Bumped version to 1.1.0 in `setup.py`. - Improved error handling in `downloader.py` with detailed console output using `rich`. - Added parameter validation checks for asset type, time period, and data frequency. - Introduced new test cases for error scenarios in `tests/test_error_cases.py`. - Added a dummy zip file for testing purposes.
Feature/1.1.0/renewal
- Added support for downloading data for specific symbols in the BinanceBulkDownloader class. - Updated README.md with examples for downloading single and multiple symbols. - Introduced a new example script for downloading spot market data for specific symbols. - Added comprehensive tests for symbol filtering in the downloader, including cases for single and multiple symbols, as well as handling invalid and empty symbol lists. - Removed a dummy zip file from the test directory.
- Removed actual download calls and replaced them with checks for parameter validation using _check_params() method. - Updated test cases to ensure valid parameters do not raise errors. - Adjusted data frequency and time period settings for multiple symbols tests. - Enhanced the test for invalid symbols to verify that no files are returned for invalid inputs. - Ensured that tests for empty symbols list validate parameter handling without performing downloads.
… progress display - Refactored the _get_file_list_from_s3_bucket method to include a live progress display while fetching files from S3. - Updated the constructor docstring to clarify symbol handling and added support for downloading multiple symbols more effectively. - Improved error handling during file downloads and unzipping processes. - Adjusted example scripts to reflect changes in symbol handling and data frequency. - Enhanced tests for spot market symbols to validate parameter handling and ensure correct symbol filtering.
- Enhanced examples for downloading single and multiple symbols by adding parameters for data type, data frequency, and asset type. - Updated the instantiation of BinanceBulkDownloader to include new options for improved data handling and clarity.
- Introduced a fixture to mock S3 responses for spot market symbols, allowing for more controlled testing. - Updated the test for spot symbols to utilize the mock response, ensuring accurate validation of symbol filtering without actual S3 calls. - Improved assertions to validate prefix and file list conditions based on symbol inputs, enhancing test reliability and clarity.
- Updated the GitHub Actions workflow for pytest to streamline Python setup and dependency installation. - Enhanced test documentation in test_spot_symbols.py by translating comments to English for better clarity and consistency. - Removed unnecessary comments to improve code readability.
Feature/1.1.0/spot filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.