-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create genesis struct. and generate bootstrap and faucet accounts #4
Create genesis struct. and generate bootstrap and faucet accounts #4
Conversation
5429d98
to
9e78374
Compare
b338c88
to
c2d1c1b
Compare
5e9bbc8
to
a642c1b
Compare
if config_dir.exists() { | ||
std::fs::remove_dir_all(&config_dir).unwrap(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe could have a subfolder that named by an unique hash 🤔 I guess that I couldn't run two cluster in the same time in the current logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya so i was going to add that functionality at the end. but it may make sense to add it now. probably easier. do you want to pull a specific git hash from agave/
or also any forked repo of agave
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can do both 🤔 (am I too greedy haha)
I will have a buildkite pipeline UI for this tool after this tool get fully commit. I will expect that may be two or more people trigger this one at the same time
nvm. a bad example. I guess we can have this feature later. I saw you have bunches PRs after this one. we can focus on the more important things!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok sounds good. its definitely on my list! and in the monorepo work that i am porting here. we can deploy multiple clusters but only through release-channels. commits will be good. it's a little more complicated for deploying multiple validator versions so that's why i was saving until later
src/genesis.rs
Outdated
match validator_type { | ||
ValidatorType::Bootstrap | ValidatorType::Standard => (), | ||
ValidatorType::RPC => { | ||
account_types.pop(); // no vote-account for RPC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I guess I missed something here. why do we need a stake-account for an RPC node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are correct. my mind here got mixed up between client and Rpc node. will fix
1e73523
to
c48a3b8
Compare
c48a3b8
to
ae54104
Compare
ae54104
to
85b4b6d
Compare
Summary of Changes
ValidatorType
enumNOTE: Had to change
reqwest
version to0.11.23
from0.12.2
. Dependency issues withsolana-core
,aes-gcm-siv
, andsubtle
This PR #3 must be merged before this one!
4th PR in a series of PRs that will build out the monogon testing framework for deploying validator clusters on Kubernetes
Previous PRs: