[fix] return signature for send and confirm factories #109
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5f9432b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nickfrosty
changed the title
BundleMonUnchanged files (127)
Total files change +2B 0% Final result: ✅ View report in BundleMon website ➡️ |
steveluscher
requested changes
Feb 12, 2025
There was a problem hiding this comment.
We did this super on purpose to break the connection in people's minds between:
- a transaction being confirmed
- a signature for that transaction being available
You don't have to wait for a transaction to be confirmed to obtain the signature, because the signature is a function of the private key and the message. We encourage folks to obtain the signature early, as in the example here, so that they can make use of it in their app earlier.
solana-web3.js/examples/transfer-lamports/src/example.ts
Lines 177 to 180 in 1faa88c
|
I know you don't have to, and that the signature is available as soon as it is signed. And that the examples are also showing how to get it. |
|
Because it makes waiting for the signature ergonomic. We want to discourage waiting for signatures, and encourage computing signatures pre-send, because waiting for anything can make apps feel less responsive. |
|
okay I guess just close the pr instead of requesting changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
sendAndConfirmDurableNonceTransactionFactoryandsendAndConfirmTransactionFactoryfactories return aPromise<void>while the underlyingsendTransaction_INTERNAL_ONLY_DO_NOT_EXPORTreturns aPromise<Signature>Summary of Changes
Fix the return type of both factories to return the signature that they already have due to just confirming it.
sendTransaction_INTERNAL_ONLY_DO_NOT_EXPORTalready imports theSignaturetype so this does not add a new dep