Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify and implement Solana Pay Transaction Requests #77

Merged
merged 122 commits into from
Apr 29, 2022
Merged

Specify and implement Solana Pay Transaction Requests #77

merged 122 commits into from
Apr 29, 2022

Conversation

jordaaash
Copy link
Collaborator

@jordaaash jordaaash commented Feb 12, 2022 •
edited
Loading

Rationale is covered in #26 (Note: the format described in that issue is superseded by this spec).

This PR specifies and implements Transaction Requests as a new format. Read the new spec.

This PR also substantially refactors the Transfer Request implementation (but the spec is compatible).

@vercel
Copy link

vercel bot commented Feb 12, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

solana-pay-docs – ./docs

🔍 Inspect: https://vercel.com/solana-labs/solana-pay-docs/5HwA637SSLXsZJyKug2eYbC1Ckd4
✅ Preview: https://solana-pay-docs-git-link-request-solana-labs.vercel.app

solana-pay – ./point-of-sale

🔍 Inspect: https://vercel.com/solana-labs/solana-pay/6NwqdZyuLm44NFSSa6Ub1rEP5Duu
✅ Preview: https://solana-pay-git-link-request-solana-labs.vercel.app

[Deployment for d0e4e0b failed]

@jordaaash jordaaash mentioned this pull request Feb 12, 2022
Closed
@jordaaash jordaaash mentioned this pull request Feb 12, 2022
Open
mcintyre94
mcintyre94 reviewed Feb 12, 2022
View reviewed changes
core/src/parseURL.ts Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Apr 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
solana-pay ❌ Failed (Inspect) Apr 29, 2022 at 4:16PM (UTC)
solana-pay-docs ✅ Ready (Inspect) Visit Preview Apr 29, 2022 at 4:16PM (UTC)

@jordaaash jordaaash merged commit b8da65e into master Apr 29, 2022
@jordaaash jordaaash deleted the link-request branch June 15, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonok-edm antonok-edm antonok-edm left review comments

@mcintyre94 mcintyre94 mcintyre94 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jordaaash @PaulFidika @mcintyre94 @Ajayneueworld @vpontis @antonok-edm @cogoo