Cleanup - JIT x86 registers #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
cleanup/jit_x86_registers
branch
from
dc6476a to
74fc372
Compare
LucasSte
reviewed
Dec 21, 2024
| @@ -408,8 +423,8 @@ impl X86Instruction { | |||
| } else { | |||
| 0x81 | |||
| }, | |||
| first_operand: RDI, | |||
| second_operand: destination, | |||
| first_operand: 7, | |||
There was a problem hiding this comment.
Why not the register name?
There was a problem hiding this comment.
Never was a register in the first place but an opcode extension. Just had the named constant which happened to have the same value.
LucasSte
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.