Fix - test_code_length_estimate() #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
fix/test_code_length_estimate
branch
2 times, most recently
from
3cf48f4 to
7b01ed7
Compare
LucasSte
reviewed
Dec 19, 2024
| for sbpf_version in [SBPFVersion::V0, SBPFVersion::V3] { | ||
| println!("opcode;machine_code_length_per_instruction;assembly"); |
There was a problem hiding this comment.
It enables one to run the test with --nocapture and get a CSV of the machine_code_length_per_instruction.
| }; | ||
| for pc in 0..INSTRUCTION_COUNT { | ||
| prog[pc * ebpf::INSN_SIZE] = opcode; | ||
| prog[pc * ebpf::INSN_SIZE + 1] = registers; | ||
| prog[pc * ebpf::INSN_SIZE + 2] = 0xFF; | ||
| prog[pc * ebpf::INSN_SIZE + 3] = 0xFF; | ||
| let offset = 7_u16.wrapping_sub(pc as u16); |
There was a problem hiding this comment.
Is this subtraction supposed to create randomness?
There was a problem hiding this comment.
It is for having relative jump offsets in conditional branches. This way some point forward and others backward. Otherwise they would be -1 and always point to themselves.
src/jit.rs
Outdated
| @@ -1900,12 +1912,19 @@ mod tests { | |||
| (machine_code_length_per_instruction + 0.5) as usize | |||
There was a problem hiding this comment.
The floating point division and the 0.5 addition aren't necessary here.
Lichtso
force-pushed
the
fix/test_code_length_estimate
branch
from
7b01ed7 to
ae750f7
Compare
LucasSte
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.